Add MAX32657 NS Board #88706

ozersa · 2025-04-16T10:21:33Z

Add MAX32657 NS board support.

~~This PR will be enabled after: #88651~~

Blinky Example Output:

github-actions · 2025-04-16T10:23:07Z

The following west manifest projects have changed revision in this Pull Request:

Name	Old Revision	New Revision	Diff
trusted-firmware-m	zephyrproject-rtos/trusted-firmware-m@`6473899`	zephyrproject-rtos/trusted-firmware-m@`c150f48` (`main`)	zephyrproject-rtos/[email protected]

✅ All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

soc/adi/max32/Kconfig

nordicjm · 2025-04-17T09:33:24Z

boards/adi/max32657evkit/Kconfig.max32657evkit

@@ -2,4 +2,5 @@
 # SPDX-License-Identifier: Apache-2.0

 config BOARD_MAX32657EVKIT
-	select SOC_MAX32657 if BOARD_MAX32657EVKIT_MAX32657
+	select SOC_MAX32657 if BOARD_MAX32657EVKIT_MAX32657 ||	\
+						   BOARD_MAX32657EVKIT_MAX32657_NS


fix alignment

My local tab size was 4, so missed this one, updated it as 8 and fixed. thanks.

nordicjm · 2025-04-17T09:33:42Z

boards/adi/max32657evkit/doc/index.rst

+BOARD: max32657evkit/max32657/ns
+================================
+
+The ``max32657evkit/max32657/ns`` board configuration is used to build the secure firmware


board target, no such term as board configuration in zephyr

Added to classify them to simplify readability. I can update it if require?

BOARD: max32657evkit/max32657

BOARD: max32657evkit/max32657/ns

ozersa · 2025-05-13T11:47:57Z

@tomi-font @Vge0rge @valentinkorenblit
Seems below commit break the TF-M builds for all boards, fyi.
zephyrproject-rtos/trusted-firmware-m@6473899 merged by zephyrproject-rtos/trusted-firmware-m#132

https://github.com/zephyrproject-rtos/zephyr/actions/runs/14994134092/job/42124527322?pr=88706

tomi-font · 2025-05-13T12:12:25Z

Seems below commit break the TF-M builds for all boards, fyi.

It's happening (only) on your PR because that PR was merged while #89370 is still waiting for @stephanosio's approval. I'd say either wait for it to be merged, or cherry pick that PR into your PR if you want to see CI results, but anyway in the end the other PR will have to go in first.

Update tf-m node to get MAX32657 support Signed-off-by: Sadik Ozer <[email protected]>

This commit adds MAX32657 Non-Secure peripheral support Signed-off-by: Sadik Ozer <[email protected]>

ozersa · 2025-05-14T09:39:01Z

Rebased onto main to get #89370

boards/adi/max32657evkit/Kconfig.defconfig

boards/adi/max32657evkit/doc/index.rst

tomi-font · 2025-05-14T11:06:59Z

boards/adi/max32657evkit/doc/index.rst

+:kconfig:option:`CONFIG_TRUSTED_EXECUTION_SECURE` to ``y`` and
+:kconfig:option:`CONFIG_BUILD_WITH_TFM` to ``n``


Parentheses maybe?

Sure, added.

tomi-font · 2025-05-14T11:07:24Z

boards/adi/max32657evkit/doc/index.rst

+BOARD: max32657evkit/max32657/ns
+================================
+
+The ``max32657evkit/max32657/ns`` target is used to build the secure firmware


No, not just board or target. Board target.

Suggested change

The ``max32657evkit/max32657/ns`` target is used to build the secure firmware

The ``max32657evkit/max32657/ns`` board target is used to build the secure firmware

Updated, thanks.

This commit enables max32657 NS board support To build: - west build -b max32657evkit/max32657/ns -p Signed-off-by: Sadik Ozer <[email protected]>

MAX32657 has one UART interface, It can be used either on TF-M or Zephyr Enabling debug (TFM_SPM_LOG_LEVEL || TFM_PARTITION_LOG_LEVEL) will transfer it to the TF-M side Disabling TF-M debug will transfer it to the Zephyr side. This commit disable TFM debugs Signed-off-by: Sadik Ozer <[email protected]>

This commit provides flashing tfm_merged.hex (includes mcuboot+tfm+ns_image) on default. Signed-off-by: Mert Ekren <[email protected]>

JWT test fails on max32657evkit/max32657/ns board, due to it requries hardware TRNG on TF-M side which not activated yet until it's issue been fixed it is excluded from automated test to workflow been succeeded Signed-off-by: Sadik Ozer <[email protected]>

This commit enables secure_partion sample for max32657evkit NS board Signed-off-by: Sadik Ozer <[email protected]>

This commit enable psa_protected_storage test for max32657evkit/ns board Signed-off-by: Sadik Ozer <[email protected]>

Update psa_crypto test not work on MAX32657 This commit enable/disable flags for MAX32657 to make it works for MAX32657. Signed-off-by: Sadik Ozer <[email protected]>

Set HAL_ADI_PATH to TF-M uses hal_adi that comes with zephyr. Signed-off-by: Sadik Ozer <[email protected]>

tomi-font

Functional changes look good. Didn't check the documentation or DT stuff in detail.

sonarqubecloud · 2025-05-14T11:50:33Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

ozersa · 2025-05-16T06:25:32Z

@nordicjm please revisit.

tomi-font · 2025-05-16T07:48:38Z

FYI I see he's off this week.

tomi-font · 2025-05-16T07:48:55Z

@d3zd3z please review.

valeriosetti

I left some minor comment. Not mandatory to address them, but it would be nice to do in case you update the PR for some other reason.

valeriosetti · 2025-05-19T10:25:01Z

soc/adi/max32/Kconfig

+config BUILD_WITH_TFM
+	default y if TRUSTED_EXECUTION_NONSECURE
+	help
+	  Auto set WITH_TFM for a Non-Secure version of the board,


Suggested change

Auto set WITH_TFM for a Non-Secure version of the board,

Auto set BUILD_WITH_TFM for a Non-Secure version of the board.

valeriosetti · 2025-05-19T10:27:33Z

boards/adi/max32657evkit/max32657evkit_max32657_ns.dts

+		/*
+		 * slot1_partition: partition@f0000 {
+		 *  label = "image-1";
+		 *	reg = <0xf0000 DT_SIZE_K(0)>;
+		 * };
+		 * slot1_ns_partition: partition@f0000 {
+		 *	label = "image-1-nonsecure";
+		 *	reg = <0xf0000 DT_SIZE_K(0)>;
+		 * };
+		 */


I guess this slot1_ nodes are somehow related to McuBoot update process, but it would be nice to add a short comment which explains why we have some code commented out and when it might be needed to uncomment it. Wdyt?

valeriosetti · 2025-05-19T10:32:30Z

tests/subsys/jwt/testcase.yaml

@@ -8,6 +8,8 @@ common:
    - qemu_x86
  extra_configs:
    - CONFIG_TEST_RANDOM_GENERATOR=y
+  platform_exclude:


The code change is OK, but there's a typo in the commit message: Exlucde --> Exclude.

ozersa mentioned this pull request Apr 16, 2025

Add MAX32657 #88651

Merged

github-actions bot added manifest manifest-hal_adi manifest-trusted-firmware-m DNM (manifest) This PR should not be merged (controlled by action-manifest) labels Apr 16, 2025

ozersa mentioned this pull request Apr 16, 2025

update to 2.1.2 zephyrproject-rtos/trusted-firmware-m#130

Merged

nordicjm requested changes Apr 17, 2025

View reviewed changes

ozersa force-pushed the add-MAX32657-NS branch 3 times, most recently from 03b0cb7 to 88f3b8d Compare April 24, 2025 07:11

ozersa force-pushed the add-MAX32657-NS branch from 88f3b8d to 01c5f03 Compare April 29, 2025 08:22

ozersa mentioned this pull request Apr 29, 2025

Cherry pick adi/max32657 platform support zephyrproject-rtos/trusted-firmware-m#128

Merged

ozersa marked this pull request as ready for review April 29, 2025 08:29

github-actions bot added platform: ADI Analog Devices, Inc. area: TF-M ARM Trusted Firmware-M (TF-M) area: Samples Samples area: JSON labels Apr 29, 2025

github-actions bot requested review from d3zd3z, galak, ithinuel, kartben, MaureenHelm, microbuilder, nashif, ttmut, valeriosetti, Vge0rge, wearyzen and yasinustunerg April 29, 2025 08:30

ozersa added 2 commits May 14, 2025 12:26

manifest: Update tf-m module for MAX32657

28cc41c

Update tf-m node to get MAX32657 support Signed-off-by: Sadik Ozer <[email protected]>

soc: Add the MAX32657 NS Peripheral

0fb09d5

This commit adds MAX32657 Non-Secure peripheral support Signed-off-by: Sadik Ozer <[email protected]>

ozersa force-pushed the add-MAX32657-NS branch from 33e8d4e to 3a9642c Compare May 14, 2025 09:27

tomi-font requested changes May 14, 2025

View reviewed changes

ozersa force-pushed the add-MAX32657-NS branch from 3a9642c to db6acb4 Compare May 14, 2025 10:42

tomi-font reviewed May 14, 2025

View reviewed changes

ozersa and others added 8 commits May 14, 2025 14:18

boards: Add MAX32657EVKit NS board

09fb5f0

This commit enables max32657 NS board support To build: - west build -b max32657evkit/max32657/ns -p Signed-off-by: Sadik Ozer <[email protected]>

boards: max32657evkit/max32657/ns: flash tfm_merged.hex on default

27a9b25

This commit provides flashing tfm_merged.hex (includes mcuboot+tfm+ns_image) on default. Signed-off-by: Mert Ekren <[email protected]>

samples: tfm_integration: Enable secure_partion on max32657evkit

f72bcb8

This commit enables secure_partion sample for max32657evkit NS board Signed-off-by: Sadik Ozer <[email protected]>

samples: tfm_integration: Enable psa_protected test for max32657evkit

38bcee2

This commit enable psa_protected_storage test for max32657evkit/ns board Signed-off-by: Sadik Ozer <[email protected]>

samples: tfm_integration: psa_crypto: To works on MAX32657

ba148cc

Update psa_crypto test not work on MAX32657 This commit enable/disable flags for MAX32657 to make it works for MAX32657. Signed-off-by: Sadik Ozer <[email protected]>

soc: adi: Do not download hal_adi for TF-M build

f3058cc

Set HAL_ADI_PATH to TF-M uses hal_adi that comes with zephyr. Signed-off-by: Sadik Ozer <[email protected]>

ozersa force-pushed the add-MAX32657-NS branch from db6acb4 to f3058cc Compare May 14, 2025 11:21

tomi-font approved these changes May 14, 2025

View reviewed changes

tomi-font requested a review from nordicjm May 14, 2025 11:24

MaureenHelm approved these changes May 15, 2025

View reviewed changes

nordicjm approved these changes May 19, 2025

View reviewed changes

valeriosetti reviewed May 19, 2025

View reviewed changes

d3zd3z approved these changes May 20, 2025

View reviewed changes

kartben merged commit 7898a51 into zephyrproject-rtos:main May 21, 2025
30 checks passed

ozersa deleted the add-MAX32657-NS branch May 21, 2025 06:06

		:kconfig:option:`CONFIG_TRUSTED_EXECUTION_SECURE` to ``y`` and
		:kconfig:option:`CONFIG_BUILD_WITH_TFM` to ``n``

	The ``max32657evkit/max32657/ns`` target is used to build the secure firmware
	The ``max32657evkit/max32657/ns`` board target is used to build the secure firmware

	Auto set WITH_TFM for a Non-Secure version of the board,
	Auto set BUILD_WITH_TFM for a Non-Secure version of the board.

Add MAX32657 NS Board #88706

Add MAX32657 NS Board #88706

Uh oh!

Conversation

ozersa commented Apr 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Apr 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ozersa commented May 13, 2025

Uh oh!

tomi-font commented May 13, 2025

Uh oh!

ozersa commented May 14, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tomi-font left a comment

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented May 14, 2025

Quality Gate passed

Uh oh!

ozersa commented May 16, 2025

Uh oh!

tomi-font commented May 16, 2025

Uh oh!

tomi-font commented May 16, 2025

Uh oh!

valeriosetti left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ozersa commented Apr 16, 2025 •

edited

Loading

github-actions bot commented Apr 16, 2025 •

edited

Loading